doc: edit N-API introductory material in Collaborator Guide #26051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use shorter, clearer sentences. Remove passive voice and personal pronouns.
thefourtheye
approved these changes
Feb 12, 2019
cjihrig
approved these changes
Feb 12, 2019
Trott
added
the
author ready
jasnell
approved these changes
Feb 12, 2019
lpinca
approved these changes
Feb 12, 2019
|
Landed in 3f9beab |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 14, 2019
Use shorter, clearer sentences. Remove passive voice and personal pronouns. PR-URL: nodejs#26051 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 14, 2019
Use shorter, clearer sentences. Remove passive voice and personal pronouns. PR-URL: #26051 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use shorter, clearer sentences. Remove passive voice and personal
pronouns.
Review from @nodejs/n-api would be appreciated. I especially want to make sure this sentence is correct: "Existing N-API APIs cannot change or disappear, even in semver-major releases." Is that always true or merely often true?
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes