Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspector: make sure timer handles are cleaned up #26088

Closed
wants to merge 1 commit into from

Commits on Feb 14, 2019

  1. inspector: make sure timer handles are cleaned up

    It is not obvious that timer handles are cleaned up properly
    when the current `Environment` exits, nor that the `Environment`
    knows to keep track of the closing handles.
    
    This change may not be necessary, because timer handles
    close without non-trivial delay (i.e. at the end of the current
    event loop term), and JS-based inspector sessions (which are
    the only ones we can easily test) are destroyed when cleaning up,
    closing the timers as a result. I don’t know what happens
    for other kinds of inspector sessions, though.
    addaleax committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    d4d34ae View commit details
    Browse the repository at this point in the history