test: add --test-root option to test.py #26093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we can specify a custom path for the test folder, e.g. when building addons separately from the source tree.
nodejs-github-bot
added
test
joyeecheung
approved these changes
Feb 14, 2019
addaleax
approved these changes
Feb 14, 2019
Trott
added
the
author ready
jasnell
approved these changes
Feb 15, 2019
|
Landed in d1d9dab |
pull bot
pushed a commit
to Rachelmorrell/node
that referenced
this pull request
Feb 17, 2019
This way we can specify a custom path for the test folder, e.g. when building addons separately from the source tree. PR-URL: nodejs#26093 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 17, 2019
This way we can specify a custom path for the test folder, e.g. when building addons separately from the source tree. PR-URL: #26093 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
This way we can specify a custom path for the test folder, e.g. when building addons separately from the source tree. PR-URL: #26093 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we can specify a custom path for the test folder, e.g.
when building addons separately from the source tree.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes