Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: apply clang-tidy rule modernize-use-override #26103

Closed
wants to merge 1 commit into from
Closed

src: apply clang-tidy rule modernize-use-override #26103

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Feb 14, 2019
@addaleax
Copy link
Member

addaleax commented Feb 17, 2019 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/20839/ (:white_check_mark:)

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 17, 2019
@danbev
Copy link
Contributor

danbev commented Feb 18, 2019

Landed in c3d8891.

@danbev danbev closed this Feb 18, 2019
danbev pushed a commit that referenced this pull request Feb 18, 2019
@gengjiawen @danbev
src: apply clang-tidy rule modernize-use-override
c3d8891 
PR-URL: #26103
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Feb 18, 2019
@gengjiawen @addaleax
src: apply clang-tidy rule modernize-use-override
60b373c 
PR-URL: #26103
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@gengjiawen @rvagg
src: apply clang-tidy rule modernize-use-override
e6949b4 
PR-URL: #26103
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gengjiawen @addaleax @danbev @jasnell @nodejs-github-bot