Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adjust test-benchmark-http for new benchmark #26107

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 14, 2019

Fixes test-benchmark-http to accommodate
da0dc51.

Please 👍 here to fast-track. node-daily-master CI will be red until this lands. (Benchmark tests are not run in regular CI.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Fixes test-benchmark-http to accommodate
da0dc51.
@Trott Trott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 14, 2019
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 14, 2019
@Trott
Copy link
Member Author

Trott commented Feb 14, 2019

@richardlau
Copy link
Member

Duplicate of #26101?

@Trott
Copy link
Member Author

Trott commented Feb 14, 2019

Duplicate of #26101?

Yup. Closing.

@Trott Trott closed this Feb 14, 2019
@Trott Trott deleted the fix-http-benchmark-test branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants