Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: increase coverage of node_report_module.cc #26116

Merged
merged 1 commit into from
Feb 18, 2019
Merged

test: increase coverage of node_report_module.cc #26116

merged 1 commit into from
Feb 18, 2019

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Feb 14, 2019 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@richardlau build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2613/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 14, 2019
@richardlau richardlau added the report Issues and PRs related to process.report. label Feb 14, 2019
@addaleax
Copy link
Member

addaleax commented Feb 17, 2019 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/20840/

@richardlau
Copy link
Member Author

richardlau commented Feb 18, 2019 •
edited
Loading

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20870/ (:heavy_check_mark:)

@richardlau
test: increase coverage of node_report_module.cc
146868c 
PR-URL: nodejs#26116
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@richardlau
Copy link
Member Author

Landed in 146868c.

@richardlau richardlau merged commit 146868c into nodejs:master Feb 18, 2019
addaleax pushed a commit that referenced this pull request Feb 19, 2019
@richardlau @addaleax
test: increase coverage of node_report_module.cc
06a15b6 
PR-URL: #26116
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@richardlau @rvagg
test: increase coverage of node_report_module.cc
38a87d5 
PR-URL: #26116
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
report Issues and PRs related to process.report. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@richardlau @nodejs-github-bot @addaleax @jasnell @Trott @cjihrig @BethGriggs