Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: converted element to lowercase in tty.js #26121

Closed
wants to merge 1 commit into from
Closed

lib: converted element to lowercase in tty.js #26121

wants to merge 1 commit into from

Conversation

abshek
Copy link
Contributor

@abshek abshek commented Feb 15, 2019 •
edited
Loading

Converted the first element "Eterm" in TERM_ENVS array to "eterm"

Fixes: #26077

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@abshek
lib: converted element to lowercase in tty.js
543fdfd 
Converted the first element "Eterm" in TERM_ENVS array to "eterm"

Fixes: nodejs#26077
@nodejs-github-bot nodejs-github-bot added the tty Issues and PRs related to the tty subsystem. label Feb 15, 2019
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/20841/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 17, 2019
@danbev
Copy link
Contributor

danbev commented Feb 18, 2019 •
edited
Loading

Re-run of failing node-test-commit-aix (✔️)

@danbev
Copy link
Contributor

danbev commented Feb 19, 2019

Landed in 17820ec.

@danbev danbev closed this Feb 19, 2019
danbev pushed a commit that referenced this pull request Feb 19, 2019
@abshek @danbev
lib: converted element to lowercase in tty.js
17820ec 
Converted the first element "Eterm" in TERM_ENVS array to "eterm"

PR-URL: #26121
Fixes: #26077
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@addaleax
Copy link
Member

(This should probably have landed with a tty: prefix, sorry for not mentioning that during review.)

addaleax pushed a commit that referenced this pull request Feb 19, 2019
@abshek @addaleax
lib: converted element to lowercase in tty.js
faa1f3d 
Converted the first element "Eterm" in TERM_ENVS array to "eterm"

PR-URL: #26121
Fixes: #26077
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@abshek @rvagg
lib: converted element to lowercase in tty.js
bf61050 
Converted the first element "Eterm" in TERM_ENVS array to "eterm"

PR-URL: #26121
Fixes: #26077
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starkwang starkwang starkwang approved these changes

@richardlau richardlau richardlau approved these changes

@JungMinu JungMinu JungMinu approved these changes

@hiroppy hiroppy hiroppy approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@antsmartian antsmartian antsmartian approved these changes

@jasnell jasnell jasnell approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tty Issues and PRs related to the tty subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: 'Eterm' → 'eterm' in getColorDepth