Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix notable changes in v11 changelog #26132

Closed
wants to merge 3 commits into from
Closed

doc: fix notable changes in v11 changelog #26132

wants to merge 3 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Feb 15, 2019

No description provided.

@nodejs-github-bot
Copy link
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2622/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 15, 2019
@cjihrig
Copy link
Contributor

cjihrig commented Feb 15, 2019

Mostly a duplicate of #26129?

@targos
Copy link
Member Author

targos commented Feb 15, 2019

@cjihrig yes, I missed that PR. I'll update after it's landed

@targos
Copy link
Member Author

targos commented Feb 16, 2019

updated

@vsemozhetbyt @targos
Update doc/changelogs/CHANGELOG_V11.md
55c9d0c 
Co-Authored-By: targos <targos@protonmail.com>
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 16, 2019
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@addaleax
Copy link
Member

Landed in 48491ce

@addaleax addaleax closed this Feb 17, 2019
@targos targos deleted the notable-fix branch October 17, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckotzbauer ckotzbauer ckotzbauer approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@targos @nodejs-github-bot @cjihrig @vsemozhetbyt @addaleax @jasnell @BethGriggs @ckotzbauer