Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: add missing includes to build with vtune support #26136

Closed
wants to merge 1 commit into from

Conversation

uttampawar
Copy link
Contributor

Added missing includes (v8-vtune.h) in environment.cc to be able to build with vtune profiling support.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 15, 2019
@uttampawar uttampawar changed the title Fix for the Node.js build failure with --enable-vtune-profiling option src: add missing includes to build with vtune support Feb 15, 2019
@addaleax
Copy link
Member

addaleax commented Feb 18, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20863/ (:heavy_check_mark:)

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 18, 2019
@gabrielschulhof
Copy link
Contributor

Landed in 129516d.

gabrielschulhof pushed a commit that referenced this pull request Feb 19, 2019
`v8-vtune.h` must be included in order to be able to build with vtune
support.

PR-URL: #26136
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax pushed a commit that referenced this pull request Feb 21, 2019
`v8-vtune.h` must be included in order to be able to build with vtune
support.

PR-URL: #26136
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
rvagg pushed a commit that referenced this pull request Feb 28, 2019
`v8-vtune.h` must be included in order to be able to build with vtune
support.

PR-URL: #26136
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@uttampawar uttampawar deleted the vtune-build-issue branch March 6, 2019 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants