Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: remove the useless GitHub Account #26146

Closed
wants to merge 3 commits into from
Closed

meta: remove the useless GitHub Account #26146

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 16, 2019

Due to maledong_private@qq.com is useless because I cannot log in
with the email address (GitHub doesn't support qq mail well),
and I've successfully changed my email account to maledong_github@outlook.com
instead. So I removed my old useless email address and keep the new one
for the same account 'MaleDong', because there're two 'MaleDong' Accounts and
they are both pointing to me.

Here're the images:
email

profiles


  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Feb 16, 2019
@ZYSzys
Copy link
Member

ZYSzys commented Feb 16, 2019

AFAIK, this file was generated by tools/update-authors.js and stat from git log.

node/AUTHORS

Line 2321 in e74019f

# Generated by tools/update-authors.js

Seems not suitable to change manually 🤔.(Please correct me if I'm wrong)

@ghost ghost changed the title chore: remove the useless GitHub Account meta: remove the useless GitHub Account Feb 16, 2019
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As has been pointed out, AUTHORS is generated by tooling, so if you remove the entry manually it's just going to be readded the next time the tool is run based on your previous commits.

What you should do instead is edit .mailmap and map your old email address to your current one.

@ghost
Copy link
Author

ghost commented Feb 16, 2019

@richardlau:Thanks! I've added my own email account address into the map file, because I didn't find it yet.

Due to `maledong_private@qq.com` is useless because I cannot log
in with the email address (GitHub doesn't support `qq` mail well),
and I've successfully changed my email account to
`maledong_github@outlook.com` instead.
So I removed my old useless email address and keep the new
one for the same account 'MaleDong', because there're two
'MaleDong' Accounts and they are both pointing to me.

The final solution is that to add my own email account address
into the '.mailmap' to let AUTHORS re-generated.
.mailmap Outdated Show resolved Hide resolved
@jasnell
Copy link
Member

jasnell commented Feb 18, 2019

The AUTHORS file can be manually changed and often is when we generated it. Making this edit is fine, we'll just have to make sure the change is not undone later ;-)

remove useless email account in `AUTHOR` so as to keep the file in union with `.mailmap`
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 20, 2019
@BridgeAR
Copy link
Member

There is no linter for this, so running a CI won't make any sense in this case.

@addaleax
Copy link
Member

addaleax commented Mar 1, 2019

Landed in 43cb36b

@addaleax addaleax closed this Mar 1, 2019
addaleax pushed a commit that referenced this pull request Mar 1, 2019
Due to `maledong_private@qq.com` is useless because I cannot log
in with the email address (GitHub doesn't support `qq` mail well),
and I've successfully changed my email account to
`maledong_github@outlook.com` instead.
So I removed my old useless email address and keep the new
one for the same account 'MaleDong', because there're two
'MaleDong' Accounts and they are both pointing to me.

The final solution is that to add my own email account address
into the '.mailmap' to let AUTHORS re-generated.

PR-URL: #26146
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@ghost ghost deleted the RemoveUselessEmailAccount branch March 1, 2019 10:14
@ghost
Copy link
Author

ghost commented Mar 1, 2019

Thanks all!

addaleax pushed a commit that referenced this pull request Mar 1, 2019
Due to `maledong_private@qq.com` is useless because I cannot log
in with the email address (GitHub doesn't support `qq` mail well),
and I've successfully changed my email account to
`maledong_github@outlook.com` instead.
So I removed my old useless email address and keep the new
one for the same account 'MaleDong', because there're two
'MaleDong' Accounts and they are both pointing to me.

The final solution is that to add my own email account address
into the '.mailmap' to let AUTHORS re-generated.

PR-URL: #26146
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants