meta: remove the useless GitHub Account #26146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
|
AFAIK, this file was generated by tools/update-authors.js and stat from Line 2321 in e74019f Seems not suitable to change manually 🤔.(Please correct me if I'm wrong) |
ghost
changed the title
richardlau
requested changes
Feb 16, 2019
There was a problem hiding this comment.
As has been pointed out, AUTHORS is generated by tooling, so if you remove the entry manually it's just going to be readded the next time the tool is run based on your previous commits.
What you should do instead is edit .mailmap and map your old email address to your current one.
|
@richardlau：Thanks! I've added my own email account address into the map file, because I didn't find it yet. |
Due to `maledong_private@qq.com` is useless because I cannot log in with the email address (GitHub doesn't support `qq` mail well), and I've successfully changed my email account to `maledong_github@outlook.com` instead. So I removed my old useless email address and keep the new one for the same account 'MaleDong', because there're two 'MaleDong' Accounts and they are both pointing to me. The final solution is that to add my own email account address into the '.mailmap' to let AUTHORS re-generated.
richardlau
reviewed
Feb 17, 2019
richardlau
approved these changes
Feb 17, 2019
|
The |
jasnell
approved these changes
Feb 18, 2019
remove useless email account in `AUTHOR` so as to keep the file in union with `.mailmap`
BridgeAR
approved these changes
Feb 20, 2019
BridgeAR
added
the
author ready
|
There is no linter for this, so running a CI won't make any sense in this case. |
|
Landed in 43cb36b |
addaleax
pushed a commit
that referenced
this pull request
Mar 1, 2019
Due to `maledong_private@qq.com` is useless because I cannot log in with the email address (GitHub doesn't support `qq` mail well), and I've successfully changed my email account to `maledong_github@outlook.com` instead. So I removed my old useless email address and keep the new one for the same account 'MaleDong', because there're two 'MaleDong' Accounts and they are both pointing to me. The final solution is that to add my own email account address into the '.mailmap' to let AUTHORS re-generated. PR-URL: #26146 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
ghost
deleted the
|
Thanks all! |
addaleax
pushed a commit
that referenced
this pull request
Mar 1, 2019
Due to `maledong_private@qq.com` is useless because I cannot log in with the email address (GitHub doesn't support `qq` mail well), and I've successfully changed my email account to `maledong_github@outlook.com` instead. So I removed my old useless email address and keep the new one for the same account 'MaleDong', because there're two 'MaleDong' Accounts and they are both pointing to me. The final solution is that to add my own email account address into the '.mailmap' to let AUTHORS re-generated. PR-URL: #26146 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to
maledong_private@qq.comis useless because I cannot log inwith the email address (GitHub doesn't support
qqmail well),and I've successfully changed my email account to
maledong_github@outlook.cominstead. So I removed my old useless email address and keep the new one
for the same account 'MaleDong', because there're two 'MaleDong' Accounts and
they are both pointing to me.
Here're the images:
make -j4 test(UNIX), orvcbuild test(Windows) passes