Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add documentation for the defaultPort option #26152

Closed
wants to merge 2 commits into from
Closed

doc: add documentation for the defaultPort option #26152

wants to merge 2 commits into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Feb 16, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@lpinca build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2636/pipeline

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Feb 16, 2019
Trott
Trott reviewed Feb 16, 2019
View reviewed changes
doc/api/http.md Outdated Show resolved Hide resolved
@lpinca lpinca force-pushed the document/default-port branch from 8e5f130 to c39aebf Compare February 16, 2019 18:48
@addaleax
Copy link
Member

addaleax commented Mar 1, 2019

@lpinca Is this ready?

CI: https://ci.nodejs.org/job/node-test-pull-request/21088/

@lpinca
Copy link
Member Author

lpinca commented Mar 1, 2019

Yes.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 1, 2019
@lpinca
Copy link
Member Author

lpinca commented Mar 2, 2019

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21113/

@lpinca
Copy link
Member Author

lpinca commented Mar 2, 2019

Landed in 453ed05...144f876.

@lpinca lpinca closed this Mar 2, 2019
@lpinca lpinca deleted the document/default-port branch March 2, 2019 06:52
lpinca added a commit that referenced this pull request Mar 2, 2019
@lpinca
doc: add documentation for the defaultPort option
f42bf39 
PR-URL: #26152
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
lpinca added a commit that referenced this pull request Mar 2, 2019
@lpinca
doc: sort http.request() options alphabetically
144f876 
PR-URL: #26152
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit that referenced this pull request Mar 2, 2019
@lpinca @addaleax
doc: add documentation for the defaultPort option
8698255 
PR-URL: #26152
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit that referenced this pull request Mar 2, 2019
@lpinca @addaleax
doc: sort http.request() options alphabetically
3560c3a 
PR-URL: #26152
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@BridgeAR BridgeAR BridgeAR approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lpinca @nodejs-github-bot @addaleax @Trott @BridgeAR