Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: simplify TriggerNodeReport() #26174

Merged
merged 1 commit into from
Feb 20, 2019
Merged

report: simplify TriggerNodeReport() #26174

merged 1 commit into from
Feb 20, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 17, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2649/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 17, 2019
@richardlau richardlau added the report Issues and PRs related to process.report. label Feb 17, 2019
@danbev
Copy link
Contributor

danbev commented Feb 18, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20849/

@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 18, 2019 •
edited
Loading

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20873/

EDIT: CI was green.

@cjihrig
report: simplify TriggerNodeReport()
1dc22bf 
PR-URL: nodejs#26174
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit 1dc22bf into nodejs:master Feb 20, 2019
@cjihrig cjihrig deleted the report branch February 20, 2019 13:45
addaleax pushed a commit that referenced this pull request Feb 21, 2019
@cjihrig @addaleax
report: simplify TriggerNodeReport()
85c5c60 
PR-URL: #26174
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@cjihrig @rvagg
report: simplify TriggerNodeReport()
633c1ea 
PR-URL: #26174
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @nodejs-github-bot @danbev @jasnell @addaleax @richardlau