Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove mips support #26192

Closed
wants to merge 1 commit into from
Closed

Conversation

bnoordhuis
Copy link
Member

Upstream V8 is dropping support for mips/mipsel/mips64/mips64el.
This commit removes the build flags from the configure script
and some loose ends from the documentation.

Fixes: #26179

Upstream V8 is dropping support for mips/mipsel/mips64/mips64el.
This commit removes the build flags from the configure script
and some loose ends from the documentation.

Fixes: nodejs#26179
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Feb 18, 2019
@richardlau richardlau added the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 18, 2019
@richardlau
Copy link
Member

I've defensively labelled this semver-major as I don't think this should land on any of our current releases.

Copy link
Member

@hashseed hashseed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's sad to see this port being discontinued.

For those interested, this was the initial commit, nine years ago, almost exactly a year after Ryan made the initial commit for Node.js:

MIPS port initial commit

This is the first step in the MIPS port of V8. It adds assembler, disassembler and simulator for the MIPS32 architecture.

Contains stubbed out implementation of all the compiler/code generator infrastructure to make it all build.

Patch by Alexandre Rames from Sigma Designs Inc.

The ownership was transferred from Sigma Designs over to Home Jinni to Imagination Technologies to Wave Computing, with more or less the same folks working diligently to catch up with changes the V8 team made.

@Trott
Copy link
Member

Trott commented Feb 18, 2019

@Trott
Copy link
Member

Trott commented Feb 18, 2019

Despite the semver-major label, I'm guessing a CITGM run here doesn't make much sense. (Anyone who feels differently should feel free to start one.)

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 18, 2019
@danbev
Copy link
Contributor

danbev commented Feb 22, 2019

Landed in 9334e45.

@danbev danbev closed this Feb 22, 2019
danbev pushed a commit that referenced this pull request Feb 22, 2019
Upstream V8 is dropping support for mips/mipsel/mips64/mips64el.
This commit removes the build flags from the configure script
and some loose ends from the documentation.

PR-URL: #26192
Fixes: #26179
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bnoordhuis bnoordhuis deleted the fix26179 branch February 23, 2019 10:35
@BethGriggs BethGriggs mentioned this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants