Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: fix calculation in process.uptime() #26206

Closed
wants to merge 3 commits into from
Closed

process: fix calculation in process.uptime() #26206

wants to merge 3 commits into from

Commits on Feb 19, 2019

  1. process: fix calculation in process.uptime() 

    In nodejs#26016 the result returned
by process.uptime() was mistakenly set to be based in the wrong
unit. This patch fixes the calculation and makes sure the returned
value is in seconds.

Refs: nodejs#26016
    @joyeecheung @Trott
    joyeecheung authored and Trott committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    bd09f7f View commit details
    Browse the repository at this point in the history

  2. process: move test-process-uptime to parallel 

    In addition, do not make too many assumptions about the startup
time and timer latency in test-process-uptime. Instead only test
that the value is likely in the correct unit (seconds) and it should
be increasing in subsequent calls.
    @joyeecheung @Trott
    joyeecheung authored and Trott committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    a6ea194 View commit details
    Browse the repository at this point in the history

  3. fixup! process: move test-process-uptime to parallel

    @Trott
    Trott committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    fd7520e View commit details
    Browse the repository at this point in the history