test: remove node-report/test-api.js #26219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
approved these changes
Feb 20, 2019
FTR they are slightly different in the standalone module (where the tests originate) but that difference is lost in core after the changes to the defaults (in core nothing is enabled by default but the standalone module does enable some triggers by default unless invoked via the API). |
Trott
approved these changes
Feb 20, 2019
BridgeAR
approved these changes
Feb 20, 2019
|
CI: https://ci.nodejs.org/job/node-test-pull-request/20916/ EDIT: CI was green. |
Trott
added
the
author ready
jasnell
approved these changes
Feb 21, 2019
There does not appear to be any difference between this test and test/node-report/test-api-nohooks.js. PR-URL: nodejs#26219 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 25, 2019
There does not appear to be any difference between this test and test/node-report/test-api-nohooks.js. PR-URL: #26219 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
There does not appear to be any difference between this test and test/node-report/test-api-nohooks.js. PR-URL: #26219 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There does not appear to be any difference between this test and
test/node-report/test-api-nohooks.js.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes