Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve performance of test-crypto-timing-safe-equal-benchmarks #26237

Closed
wants to merge 2 commits into from
Closed

test: improve performance of test-crypto-timing-safe-equal-benchmarks #26237

wants to merge 2 commits into from

Commits on Feb 21, 2019

  1. test: improve performance of test-crypto-timing-safe-equal-benchmarks 

    Resetting require.cache() to `Object.create(null)` each time rather than
deleting the specific key results in a 10x improvement in running time.

Fixes: nodejs#25984
Refs: nodejs#26229
    @Trott
    Trott committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    3b626d2 View commit details
    Browse the repository at this point in the history

  2. squash! test: improve performance of test-crypto-timing-safe-equal-be… 

    …nchmarks

Use eval() instead....
    @Trott
    Trott committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    69655d7 View commit details
    Browse the repository at this point in the history