crypto: fix error condition in Verify::VerifyFinal #26238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fail early if key parsing failed, don't try to construct a context out of it.
nodejs-github-bot
added
c++
cjihrig
approved these changes
Feb 21, 2019
addaleax
approved these changes
Feb 21, 2019
bnoordhuis
approved these changes
Feb 21, 2019
|
Thanks for reviewing, landed in 10c3db3. |
tniessen
added a commit
that referenced
this pull request
Feb 23, 2019
Fail early if key parsing failed, don't try to construct a context out of it. PR-URL: #26238 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
addaleax
pushed a commit
that referenced
this pull request
Feb 25, 2019
Fail early if key parsing failed, don't try to construct a context out of it. PR-URL: #26238 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Fail early if key parsing failed, don't try to construct a context out of it. PR-URL: #26238 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail early if key parsing failed, don't try to construct a context out of it. Luckily, OpenSSL makes sure that we do not pass in a
nullptr, so this is not a security issue. The observable behavior is still the same under certain assumptions about the error queue at the time, so it is difficult to add a test for this.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes