Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: small improvements #26240

Closed
wants to merge 3 commits into from
Closed

repl: small improvements #26240

wants to merge 3 commits into from

Conversation

BridgeAR
Copy link
Member

Please have a look at the commit messages as description.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
repl: add more information
af48760 
This adds information about how to close the repl.
@BridgeAR
repl: add new line on ctrl+d
d37603c 
Currently the repl ends on the same line which procudes a weird
output. To prevent that, just add a new line in case of ctrl+d.
@BridgeAR
repl: hide editor mode if not used in a terminal
098ab70 
The editor mode is only useable when used as terminal. Hide it from
the user in case the repl terminal option is not set.
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2689/pipeline

@nodejs-github-bot nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Feb 21, 2019
@antsmartian
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/20938/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 21, 2019
@danbev
Copy link
Contributor

danbev commented Feb 28, 2019

Landed in ff64c67, 1976909, and df43754.

@danbev danbev closed this Feb 28, 2019
danbev pushed a commit that referenced this pull request Feb 28, 2019
@BridgeAR @danbev
repl: add more information
ff64c67 
This adds information about how to close the repl.

PR-URL: #26240
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
danbev pushed a commit that referenced this pull request Feb 28, 2019
@BridgeAR @danbev
repl: add new line on ctrl+d
1976909 
Currently the repl ends on the same line which procudes a weird
output. To prevent that, just add a new line in case of ctrl+d.

PR-URL: #26240
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
danbev pushed a commit that referenced this pull request Feb 28, 2019
@BridgeAR @danbev
repl: hide editor mode if not used in a terminal
df43754 
The editor mode is only useable when used as terminal. Hide it from
the user in case the repl terminal option is not set.

PR-URL: #26240
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
addaleax pushed a commit that referenced this pull request Mar 1, 2019
@BridgeAR @addaleax
repl: add more information
f636f15 
This adds information about how to close the repl.

PR-URL: #26240
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
addaleax pushed a commit that referenced this pull request Mar 1, 2019
@BridgeAR @addaleax
repl: add new line on ctrl+d
2fa8170 
Currently the repl ends on the same line which procudes a weird
output. To prevent that, just add a new line in case of ctrl+d.

PR-URL: #26240
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
addaleax pushed a commit that referenced this pull request Mar 1, 2019
@BridgeAR @addaleax
repl: hide editor mode if not used in a terminal
2a74a1e 
The editor mode is only useable when used as terminal. Hide it from
the user in case the repl terminal option is not set.

PR-URL: #26240
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Merged
@BridgeAR BridgeAR deleted the repl-things branch January 20, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antsmartian antsmartian antsmartian approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@addaleax addaleax addaleax approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BridgeAR @nodejs-github-bot @antsmartian @danbev @silverwind @addaleax @Fishrock123