src: remove unused Converter object #26243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
bnoordhuis
approved these changes
Feb 21, 2019
| @@ -204,7 +204,6 @@ class ConverterObject : public BaseObject, Converter { | |||
|
|
|||
| CHECK_GE(args.Length(), 3); // Converter, Buffer, Flags | |||
|
|
|||
| Converter utf8("utf8"); | |||
There was a problem hiding this comment.
I guess this has the side effect of verifying that ICU is in a sane state? It'll CHECK when ucnv_open() fails.
But if that's the reason why it's there, it really could use an explaining comment. cc @jasnell.
There was a problem hiding this comment.
I assumed (and still do) that this is a leftover from when this code was written, tbh.
addaleax
added
the
author ready
cjihrig
approved these changes
Feb 28, 2019
|
Landed in 7f8010b |
addaleax
added a commit
that referenced
this pull request
Mar 1, 2019
PR-URL: #26243 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
added a commit
that referenced
this pull request
Mar 1, 2019
PR-URL: #26243 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This was referenced Mar 11, 2021
This was referenced May 25, 2021
This was referenced May 26, 2021
This was referenced Apr 7, 2022
This was referenced Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes