lib: deprecate _stream_wrap

[sam-github]

Its unused by node, and doesn't have a reasonable use outside of node.

See: #25153
See: #16158

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• documentation is changed or added
• commit message follows commit guidelines

[nodejs-github-bot]

@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2692/pipeline

[Trott]

Runtime deprecations are semver-major so I'm labeling it that. (If there is good reason for this to go in as not-a-breaking-change, it needs TSC sign-off on that.)

[sam-github]

Definitely semver-major

[BridgeAR]

A test case would likely also be good.

[sam-github]

@BridgeAR can you point me to some examples of how deprecations are tested? I can't find one for sys, linklist, or constants (the other deprecated requires).

[BridgeAR]

@sam-github

It should be similar to e.g.,

'use strict';

const common = require('../common');

common.expectWarning('DeprecationWarning', {
  DEP0XXX: '$MESSAGE'
});

require('_stream_wrap');

[sam-github]

@BridgeAR Added test, thanks.

[sam-github]

ci: https://ci.nodejs.org/job/node-test-pull-request/20953/

[sam-github]

ci: https://ci.nodejs.org/job/node-test-pull-request/21042/

[sam-github]

ci: https://ci.nodejs.org/job/node-test-pull-request/21061/

[BridgeAR]

This requires a rebase.

[sam-github]

rebased

ci: https://ci.nodejs.org/job/node-test-pull-request/21101/

[sam-github]

Needs two TSC approvals to land a semver-major. @addaleax, you did the prep for this, want to review?

[BridgeAR]

@nodejs/tsc PTAL this still needs another LG due to being semver-major.

[BridgeAR]

CI https://ci.nodejs.org/job/node-test-pull-request/21175/

[Trott]

I'll approve this if no one else on TSC steps up to do so, but I'm guessing that any deprecation that involves a file with "stream" in the name calls for a review from @mcollina.

[mcollina]

LGTM

We can really deprecate all of the modules starting with an underscore.

[sam-github]

Landed in c7e628f