Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix metadata of DEP0114 #26250

Closed
wants to merge 1 commit into from
Closed

doc: fix metadata of DEP0114 #26250

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

The URL was unknown before creating #25338 and I forgot to update the PR with the correct URL later.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2697/pipeline

@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Feb 21, 2019
@tniessen
Copy link
Member Author

Please add 👍 here to approve fast-tracking.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 21, 2019
@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 22, 2019
@tniessen
Copy link
Member Author

Fast-tracking has been approved. Thanks for reviewing, landed in 3d4db3a.

@tniessen tniessen closed this Feb 22, 2019
tniessen added a commit that referenced this pull request Feb 22, 2019
@tniessen
doc: fix metadata of DEP0114
3d4db3a 
PR-URL: #26250
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@sam-github sam-github sam-github approved these changes

Assignees
No one assigned
Labels
deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tniessen @nodejs-github-bot @sam-github @cjihrig @BridgeAR @addaleax