doc: fix deprecation "End-of-Life" capitalization #26251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
deprecations
richardlau
approved these changes
Feb 21, 2019
BridgeAR
approved these changes
Feb 21, 2019
BridgeAR
added
the
author ready
Trott
approved these changes
Feb 21, 2019
There was a problem hiding this comment.
LGTM. Might be good to add End-Of-Life to https://github.com/Trott/remark-preset-lint-node/blob/594048a86e09993ead132df1c499fee05a239bce/index.js#L49-L55 to keep it from creeping back in.
Once this lands, I'm happy to do it, but a PR is of course welcome! |
|
I thought it would make the most sense as part of this PR, but yea, it can be separate too. |
richardlau
added a commit
to richardlau/remark-preset-lint-node
that referenced
this pull request
Feb 22, 2019
Since this was easy enough to do in GitHub's web UI editor: nodejs/remark-preset-lint-node#12 |
BridgeAR
pushed a commit
to nodejs/remark-preset-lint-node
that referenced
this pull request
Feb 22, 2019
lpinca
approved these changes
Feb 23, 2019
jasnell
approved these changes
Feb 23, 2019
|
Landed in 7e0ddf6 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Feb 23, 2019
PR-URL: nodejs#26251 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 23, 2019
Update remark-preset-lint-node to 1.4.0. This adds `End-Of-Life` as a prohibited string, favoring `End-of-Life` for consistency. Refs: nodejs#26251
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 26, 2019
Update remark-preset-lint-node to 1.4.0. This adds `End-Of-Life` as a prohibited string, favoring `End-of-Life` for consistency. Refs: nodejs#26251 PR-URL: nodejs#26281 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Mar 1, 2019
Update remark-preset-lint-node to 1.4.0. This adds `End-Of-Life` as a prohibited string, favoring `End-of-Life` for consistency. Refs: #26251 PR-URL: #26281 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Apr 23, 2019
This was referenced Apr 23, 2019
3 tasks
cjihrig
added a commit
to cjihrig/node
that referenced
this pull request
Jun 2, 2020
Update the "End-of-Life" casing in the deprecation documentation for consistency. Similar to nodejs#26251. PR-URL: nodejs#33691 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
tniessen
removed
the
author ready
Marlyfleitas
added a commit
to Marlyfleitas/Node-remark-preset-lint
that referenced
this pull request
Aug 26, 2022
patrickm68
added a commit
to patrickm68/Node-preset-lint
that referenced
this pull request
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 78 occurrences of
End-of-Lifeand two occurrences ofEnd-Of-Life.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes