Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: silence cpp lint by default #26252

Closed
wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

The cpp linter is very noisy at the moment. So use the --quiet flag
by default instead of being verbose in this case.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR BridgeAR requested a review from danbev February 21, 2019 21:02
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Feb 21, 2019
Makefile Outdated Show resolved Hide resolved
The cpp linter is very noisy at the moment. So use the --quiet flag
by default instead of being verbose in this case.
@BridgeAR
Copy link
Member Author

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 28, 2019
@BridgeAR
Copy link
Member Author

Landed in 0373836 🎉

@BridgeAR BridgeAR closed this Feb 28, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Feb 28, 2019
The cpp linter is very noisy at the moment. So use the --quiet flag
by default instead of being verbose in this case.

PR-URL: nodejs#26252
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Mar 1, 2019
The cpp linter is very noisy at the moment. So use the --quiet flag
by default instead of being verbose in this case.

PR-URL: #26252
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
refack added a commit to refack/node that referenced this pull request Mar 22, 2019
PR-URL: nodejs#26740
Refs: nodejs#26252
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR deleted the silence-lint-cpp branch January 20, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants