Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix StreamPipe cleanup & interaction with env handles #26256

Closed
wants to merge 2 commits into from
Closed

src: fix StreamPipe cleanup & interaction with env handles #26256

wants to merge 2 commits into from

Commits on Feb 21, 2019

  1. src: do not access Environment-owned handles after cleanup 

    Do not access handles that have already begun to be closed
or are closed.
    @addaleax
    addaleax committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    7b937eb View commit details
    Browse the repository at this point in the history

  2. src: clean up StreamPipe in destructor 

    In the presence of Workers, it is not safe to assume that
`StreamPipe::Unpipe()` has been called at the time when the object
is destroyed.

Instead, clean up when the destructor is called.
    @addaleax
    addaleax committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    c43d20b View commit details
    Browse the repository at this point in the history