Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker: provide process.execArgv #26267

Closed
wants to merge 4 commits into from

Conversation

addaleax
Copy link
Member

Provide process.execArgv. If an execArgv option is passed to the
Worker constructor, that option is used as its value; if not,
the parent’s process.execArgv is inherited (since that also goes
for the actual options in that case).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Feb 22, 2019
@addaleax addaleax added process Issues and PRs related to the process subsystem. worker Issues and PRs related to Worker support. and removed lib / src Issues and PRs related to general changes in the lib or src directory. labels Feb 22, 2019
@jasnell
Copy link
Member

jasnell commented Feb 23, 2019

do docs need to be updated for the execArgv option on the Worker constructor?

@addaleax
Copy link
Member Author

@jasnell Yup, added a note for that in 1da935e.

@addaleax
Copy link
Member Author

addaleax commented Mar 1, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21082/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 1, 2019
doc/api/worker_threads.md Outdated Show resolved Hide resolved
@addaleax
Copy link
Member Author

addaleax commented Mar 1, 2019

addaleax added 4 commits March 2, 2019 00:15
Provide `process.execArgv`. If an `execArgv` option is passed to the
`Worker` constructor, that option is used as its value; if not,
the parent’s `process.execArgv` is inherited (since that also goes
for the actual options in that case).
@addaleax
Copy link
Member Author

addaleax commented Mar 1, 2019

@addaleax
Copy link
Member Author

addaleax commented Mar 2, 2019

Landed in f65b4af

@addaleax addaleax closed this Mar 2, 2019
@addaleax addaleax deleted the worker-exec-argv branch March 2, 2019 12:18
addaleax added a commit that referenced this pull request Mar 2, 2019
Provide `process.execArgv`. If an `execArgv` option is passed to the
`Worker` constructor, that option is used as its value; if not,
the parent’s `process.execArgv` is inherited (since that also goes
for the actual options in that case).

PR-URL: #26267
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Mar 2, 2019
Provide `process.execArgv`. If an `execArgv` option is passed to the
`Worker` constructor, that option is used as its value; if not,
the parent’s `process.execArgv` is inherited (since that also goes
for the actual options in that case).

PR-URL: #26267
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. worker Issues and PRs related to Worker support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants