Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: refactor triggerReport() and consolidate triggerReport() tests #26268

Merged
merged 3 commits into from
Feb 26, 2019
Merged

report: refactor triggerReport() and consolidate triggerReport() tests #26268

merged 3 commits into from
Feb 26, 2019

Commits on Feb 26, 2019

  1. report: refactor triggerReport() 

    This commit fixes the triggerReport() argument validation. The
existing test is also updated, as it was not passing the Error
object to triggerReport().

PR-URL: nodejs#26268
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig
    cjihrig committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    d64aea0 View commit details
    Browse the repository at this point in the history

  2. test: consolidate triggerReport() tests 

    PR-URL: nodejs#26268
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig
    cjihrig committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    cae7232 View commit details
    Browse the repository at this point in the history

  3. test: increase triggerReport() coverage 

    PR-URL: nodejs#26268
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig
    cjihrig committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    72cf8a3 View commit details
    Browse the repository at this point in the history