Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: correct typos in various docs #26312

Closed
wants to merge 2 commits into from
Closed

doc: correct typos in various docs #26312

wants to merge 2 commits into from

Conversation

BeniCheni
Copy link
Contributor

Noticed a few typos while reading docs. Tried out corrections in this PR.

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 26, 2019
@BeniCheni
Copy link
Contributor Author

A certificate can have multiple altnames. Can you put just this one back the way it was?

@Trott, reverted to "altnames". Thanks.

@Trott
Copy link
Member

Trott commented Feb 26, 2019 •
edited
Loading

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2707/ ✅

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 26, 2019
@addaleax
Copy link
Member

addaleax commented Mar 2, 2019

Landed in 8f87080

@addaleax addaleax closed this Mar 2, 2019
addaleax pushed a commit that referenced this pull request Mar 2, 2019
@BeniCheni @addaleax
doc: correct typos in various docs
8f87080 
PR-URL: #26312
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit that referenced this pull request Mar 2, 2019
@BeniCheni @addaleax
doc: correct typos in various docs
bc5771e 
PR-URL: #26312
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BeniCheni BeniCheni deleted the doc-typos-correction branch March 2, 2019 13:36
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@BeniCheni @Trott @addaleax @jasnell @lpinca @cjihrig @BethGriggs @nodejs-github-bot