Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix up N-API support matrix #26377

Closed
wants to merge 2 commits into from
Closed

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Mar 1, 2019

The support matrix was out of date. Update
with current status.

Fixes: #25801

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

The support matrix was out of date. Update
with current status.

Fixes: nodejs#25801
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Mar 1, 2019
doc/api/n-api.md Outdated
| v10.x | | | v10.0.0 |
| | 1 | 2 | 3 | 4 |
|:-----:|:-------:|:--------:|:--------:|:--------:|
| v4.x | | | | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should EoL versions be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

@mhdawson
Copy link
Member Author

mhdawson commented Mar 4, 2019

@mhdawson
Copy link
Member Author

mhdawson commented Mar 4, 2019

CI was good, landing

@mhdawson
Copy link
Member Author

mhdawson commented Mar 4, 2019

Landed in 1bdcfa7

@mhdawson mhdawson closed this Mar 4, 2019
mhdawson added a commit that referenced this pull request Mar 4, 2019
The support matrix was out of date. Update
with current status.

Fixes: #25801

PR-URL: #26377
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
The support matrix was out of date. Update
with current status.

Fixes: nodejs#25801

PR-URL: nodejs#26377
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
| | 1 | 2 | 3 | 4 |
|:-----:|:-------:|:--------:|:--------:|:--------:|
| v6.x | | | v6.14.2* | |
| v8.x | v8.0.0* | v8.10.0* | v8.11.2 | |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhdawson it would be good to have the non-experimental versions listed. E.g. https://github.com/nodejs/abi-stable-node says that "Node.js versions 8.12.0 and above provide N-API as a stable feature"

BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
The support matrix was out of date. Update
with current status.

Fixes: #25801

PR-URL: #26377
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
@mhdawson mhdawson deleted the napi-matrix branch September 30, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc/api/n-api.md: Update version matrix
7 participants