-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix up N-API support matrix #26377
Conversation
The support matrix was out of date. Update with current status. Fixes: nodejs#25801
doc/api/n-api.md
Outdated
| v10.x | | | v10.0.0 | | ||
| | 1 | 2 | 3 | 4 | | ||
|:-----:|:-------:|:--------:|:--------:|:--------:| | ||
| v4.x | | | | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should EoL versions be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
Lite CI as it is doc only: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2759/ |
CI was good, landing |
|
The support matrix was out of date. Update with current status. Fixes: nodejs#25801 PR-URL: nodejs#26377 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
| | 1 | 2 | 3 | 4 | | ||
|:-----:|:-------:|:--------:|:--------:|:--------:| | ||
| v6.x | | | v6.14.2* | | | ||
| v8.x | v8.0.0* | v8.10.0* | v8.11.2 | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhdawson it would be good to have the non-experimental versions listed. E.g. https://github.com/nodejs/abi-stable-node says that "Node.js versions 8.12.0 and above provide N-API as a stable feature"
The support matrix was out of date. Update
with current status.
Fixes: #25801
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes