Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: bump lint-node-md-cli-rollup to version 2 #26441

Merged
merged 2 commits into from
Mar 9, 2019
Merged

tools: bump lint-node-md-cli-rollup to version 2 #26441

merged 2 commits into from
Mar 9, 2019

Conversation

refack
Copy link
Contributor

@refack refack commented Mar 4, 2019

Now with minification.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2760/pipeline

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 4, 2019
@refack
Copy link
Contributor Author

refack commented Mar 4, 2019

/CC @nodejs/linting

Trott
Trott approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 4, 2019
cjihrig
cjihrig approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@BridgeAR
Copy link
Member

BridgeAR commented Mar 8, 2019

@refack this needs a rebase

@BridgeAR BridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2019
@refack
tools: update node-lint-md-cli-rollup version 2
8da6cec 
PR-URL: nodejs#26441
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@refack
tools: update generated lint-md.js
1acf3b1 
PR-URL: nodejs#26441
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@refack
Copy link
Contributor Author

refack commented Mar 9, 2019 •
edited
Loading

Linter CI test: https://ci.nodejs.org/job/node-test-linter/26155/ ✔️

@refack refack merged commit 1acf3b1 into nodejs:master Mar 9, 2019
@refack refack deleted the lint-md-rollup2 branch March 9, 2019 00:10
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@refack @BridgeAR
tools: update node-lint-md-cli-rollup version 2
8f0a924 
PR-URL: #26441
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@refack @BridgeAR
tools: update generated lint-md.js
bda41d8 
PR-URL: #26441
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@refack @BridgeAR
tools: update node-lint-md-cli-rollup version 2
4835504 
PR-URL: #26441
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@refack @BridgeAR
tools: update generated lint-md.js
dcfdef5 
PR-URL: #26441
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@watilde watilde watilde approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@refack @nodejs-github-bot @BridgeAR @Trott @watilde @cjihrig @richardlau