Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update ESLint to 5.15.1 #26447

Merged
merged 1 commit into from
Mar 10, 2019
Merged

tools: update ESLint to 5.15.1 #26447

merged 1 commit into from
Mar 10, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 5, 2019

Update ESLint to 5.15.1

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2764/pipeline

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 5, 2019
Trott
Trott approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM.

@jasnell
Copy link
Member

jasnell commented Mar 5, 2019

Rubber stamp LGTM

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2019
@silverwind
Copy link
Contributor

Hmm, this commit has some .ts and .map files while dmn@2.1.0 should actually get rid of them.

@cjihrig
Copy link
Contributor Author

cjihrig commented Mar 6, 2019

I'll wait for #26462 to land and then run the update again before landing this.

@silverwind
Copy link
Contributor

silverwind commented Mar 6, 2019 •
edited
Loading

To answer my previous question: dmn did not find the files because it does not recurse into module sub-directories or indirect dependencies and doing so seems quite dangerous, so we have to live with these files for now, until a better solution is found.

@cjihrig
tools: update ESLint to 5.15.1
2176d63 
Update ESLint to 5.15.1

PR-URL: nodejs#26447
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@cjihrig cjihrig merged commit 2176d63 into nodejs:master Mar 10, 2019
@cjihrig cjihrig deleted the eslint branch March 10, 2019 21:22
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@cjihrig @BridgeAR
tools: update ESLint to 5.15.1
3fc4174 
Update ESLint to 5.15.1

PR-URL: #26447
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@cjihrig @BridgeAR
tools: update ESLint to 5.15.1
2c0c42d 
Update ESLint to 5.15.1

PR-URL: #26447
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@cjihrig @BridgeAR
tools: update ESLint to 5.15.1
a32c749 
Update ESLint to 5.15.1

PR-URL: #26447
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @nodejs-github-bot @jasnell @silverwind @Trott @BridgeAR