Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: refactor deprecated function in readline.js #26494

Closed

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the readline Issues and PRs related to the built-in readline module. label Mar 7, 2019
@gengjiawen gengjiawen force-pushed the rewrite_deprecated_in_readline branch from 8fed568 to e97bac7 Compare March 7, 2019 15:41
lib/readline.js Outdated Show resolved Hide resolved
@gengjiawen gengjiawen force-pushed the rewrite_deprecated_in_readline branch from e97bac7 to 1b31834 Compare March 7, 2019 15:56
@gengjiawen gengjiawen force-pushed the rewrite_deprecated_in_readline branch from 1b31834 to b8b146e Compare March 7, 2019 16:24
@BridgeAR
Copy link
Member

BridgeAR commented Mar 8, 2019

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2019
@gengjiawen
Copy link
Member Author

@BridgeAR I am not quite sure why Jenkins ci failed so many task. Should we re-trigger it ?

@BridgeAR
Copy link
Member

@gengjiawen the master branch was broken :/

CI https://ci.nodejs.org/job/node-test-pull-request/21398/

@lpinca
Copy link
Member

lpinca commented Mar 12, 2019

@BridgeAR
Copy link
Member

BridgeAR commented Mar 12, 2019

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 13, 2019
PR-URL: nodejs#26494
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR
Copy link
Member

Landed in b7568e1 🎉

@BridgeAR BridgeAR closed this Mar 13, 2019
@gengjiawen gengjiawen deleted the rewrite_deprecated_in_readline branch March 13, 2019 15:39
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
PR-URL: #26494
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 14, 2019
PR-URL: nodejs#26494
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
PR-URL: #26494
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. readline Issues and PRs related to the built-in readline module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants