Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: fix formatting and add coverage for stdout/stderr #26522

Merged
merged 2 commits into from
Mar 10, 2019
Merged

report: fix formatting and add coverage for stdout/stderr #26522

merged 2 commits into from
Mar 10, 2019

Commits on Mar 10, 2019

  1. report: fix stdout/stderr output formatting 

    This commit prevents the report and "report complete" message
from being printed on the same line.

PR-URL: nodejs#26522
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig
    cjihrig committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    24286ea View commit details
    Browse the repository at this point in the history

  2. test: cover stdout/stderr usage in triggerReport() 

    This commit adds coverage for the cases where
process.report.filename is 'stdout' or 'stderr'.

PR-URL: nodejs#26522
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig
    cjihrig committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    86aed6d View commit details
    Browse the repository at this point in the history