Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix SplitString to ignore white spaces #26545

Closed
wants to merge 1 commit into from
Closed

src: fix SplitString to ignore white spaces #26545

wants to merge 1 commit into from

Conversation

himself65
Copy link
Member

@himself65 himself65 commented Mar 9, 2019 •
edited
Loading

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 9, 2019
@himself65
Copy link
Member Author

try to fix #26521

@targos
Copy link
Member

targos commented Mar 9, 2019

Could you write a test?

@himself65
Copy link
Member Author

Could you write a test?

I will try :)

@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21391/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 10, 2019
XadillaX
XadillaX approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@XadillaX XadillaX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danbev
Copy link
Contributor

danbev commented Mar 13, 2019

Landed in 17ab2ed.

@danbev danbev closed this Mar 13, 2019
danbev pushed a commit that referenced this pull request Mar 13, 2019
@himself65 @danbev
src: fix SplitString to ignore white spaces
17ab2ed 
PR-URL: #26545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
@himself65 himself65 mentioned this pull request Mar 13, 2019
Closed
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@himself65 @BridgeAR
src: fix SplitString to ignore white spaces
48a8562 
PR-URL: #26545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
@BridgeAR BridgeAR mentioned this pull request Mar 14, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 14, 2019
@himself65 @BridgeAR
src: fix SplitString to ignore white spaces
2733e2d 
PR-URL: nodejs#26545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@himself65 @BridgeAR
src: fix SplitString to ignore white spaces
bc09d2f 
PR-URL: #26545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

@richardlau richardlau richardlau approved these changes

@XadillaX XadillaX XadillaX approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@himself65 @targos @BridgeAR @danbev @addaleax @cjihrig @XadillaX @richardlau @nodejs-github-bot