Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: create an option for setting a maximum size for uri parsing #26553

Closed
wants to merge 8 commits into from
Closed

http: create an option for setting a maximum size for uri parsing #26553

wants to merge 8 commits into from

Commits on Mar 10, 2019

  1. http: create an option for setting a maximum size for uri parsing 

    The http server wasn't able to tell exactly what caused an
HPE_HEADER_OVERFLOW, meaning it would yield a 431 error even if what
caused it was the request URI being too long.

This adds a limit to the URI sizes through a new option called
max-http-uri-size, which will be checked against the actual URIs
after on_url callback at the node_http_parser_impl file.

Fixes: nodejs#26296
Refs: expressjs/express#3898
    @caiolrm
    caiolrm committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    45fa652 View commit details
    Browse the repository at this point in the history

  2. http: fix style and naming

    @caiolrm
    caiolrm committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    3218828 View commit details
    Browse the repository at this point in the history

  3. http: fix doc added version to replaceme

    @caiolrm
    caiolrm committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    197d264 View commit details
    Browse the repository at this point in the history

  4. http: fixing comment because lint

    @caiolrm
    caiolrm committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    e7ade8b View commit details
    Browse the repository at this point in the history

  5. http: requiring common first

    @caiolrm
    caiolrm committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    78dfcf7 View commit details
    Browse the repository at this point in the history

  6. http: splitting the limit check of header and uri

    @caiolrm
    caiolrm committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    710e830 View commit details
    Browse the repository at this point in the history

  7. http: fixing tests 

    test-http-header-overflow.js:
the llhttp doesn't  count space and separator, so to generate a breaking
number of chars, just add +1 to the maxHeaderSize

test-http-max-http-headers.js:
remove the +1 that was referring to the slash of the uri, because
it's not being counted anymore
    @caiolrm
    caiolrm committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    38307dc View commit details
    Browse the repository at this point in the history

  8. http: fix the comment to reflect the actual currentSize composition

    @caiolrm
    caiolrm committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    93e384a View commit details
    Browse the repository at this point in the history