Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test case in test-http2-respond-file-304.js #26565

Closed
wants to merge 1 commit into from
Closed

test: fix test case in test-http2-respond-file-304.js #26565

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 10, 2019
BridgeAR
BridgeAR approved these changes Mar 10, 2019
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21396/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 10, 2019
@BridgeAR BridgeAR mentioned this pull request Mar 10, 2019
Closed
4 tasks
richardlau
richardlau approved these changes Mar 10, 2019
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we lint for cases of assert.strictEqual() with only a single argument?

@Trott
Copy link
Member

Trott commented Mar 10, 2019

Can we lint for cases of assert.strictEqual() with only a single argument?

I think assert.strictEqual() should throw if there is only one argument. The second argument should be required. But that's a semver-major change, I suppose.

@BridgeAR
Copy link
Member

@richardlau I added such rule in #26569.

@Trott I also thought about doing that while writing the eslint rule. I can add the validation instead - I am just not certain if it's accepted as patch or if someone wants to have it as semver-major change.

@Trott
Copy link
Member

Trott commented Mar 10, 2019

@BridgeAR I think lint for now and throw later is fine. If we never get around to throwing later, that's OK too.

@danbev
Copy link
Contributor

danbev commented Mar 13, 2019

Landed in e6fa50e.

@danbev danbev closed this Mar 13, 2019
danbev pushed a commit that referenced this pull request Mar 13, 2019
@gengjiawen @danbev
test: fix test case in test-http2-respond-file-304.js
e6fa50e 
PR-URL: #26565
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 13, 2019
@BridgeAR
lib,test: improve faulty assert usage detection
32853c0 
This improves our custom eslint rules to detect assertions to detect
assertions with only a single argument and fixes false negatives in
case unary expressions are used.
Some rules were extended to also lint our docs and tools and the lib
rule was simplified to prohibit most assertion calls.

PR-URL: nodejs#26569
Refs: nodejs#26565
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@gengjiawen @BridgeAR
test: fix test case in test-http2-respond-file-304.js
3b8c9cd 
PR-URL: #26565
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR added a commit that referenced this pull request Mar 14, 2019
@BridgeAR
lib,test: improve faulty assert usage detection
f95e015 
This improves our custom eslint rules to detect assertions to detect
assertions with only a single argument and fixes false negatives in
case unary expressions are used.
Some rules were extended to also lint our docs and tools and the lib
rule was simplified to prohibit most assertion calls.

PR-URL: #26569
Refs: #26565
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Mar 14, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 14, 2019
@gengjiawen @BridgeAR
test: fix test case in test-http2-respond-file-304.js
19c8ebd 
PR-URL: nodejs#26565
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 14, 2019
@BridgeAR
lib,test: improve faulty assert usage detection
1057335 
This improves our custom eslint rules to detect assertions to detect
assertions with only a single argument and fixes false negatives in
case unary expressions are used.
Some rules were extended to also lint our docs and tools and the lib
rule was simplified to prohibit most assertion calls.

PR-URL: nodejs#26569
Refs: nodejs#26565
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@gengjiawen @BridgeAR
test: fix test case in test-http2-respond-file-304.js
9e82ee9 
PR-URL: #26565
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR added a commit that referenced this pull request Mar 14, 2019
@BridgeAR
lib,test: improve faulty assert usage detection
1fa5004 
This improves our custom eslint rules to detect assertions to detect
assertions with only a single argument and fixes false negatives in
case unary expressions are used.
Some rules were extended to also lint our docs and tools and the lib
rule was simplified to prohibit most assertion calls.

PR-URL: #26569
Refs: #26565
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
@gengjiawen @BethGriggs
test: fix test case in test-http2-respond-file-304.js
8855395 
PR-URL: #26565
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
This was referenced May 29, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@gengjiawen @BridgeAR @Trott @danbev @jasnell @lpinca @cjihrig @richardlau @nodejs-github-bot