Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix syntax error in test-dns-idna2008.js when failing #26570

Merged
merged 1 commit into from
Mar 12, 2019
Merged

test: fix syntax error in test-dns-idna2008.js when failing #26570

merged 1 commit into from
Mar 12, 2019

Conversation

refack
Copy link
Contributor

@refack refack commented Mar 10, 2019

Refs: #25870
Refs: #26473

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@refack refack added dns Issues and PRs related to the dns subsystem. test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Mar 10, 2019
@refack refack self-assigned this Mar 10, 2019
@nodejs-github-bot
Copy link
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2848/pipeline

@refack refack mentioned this pull request Mar 10, 2019
Closed
@refack
Copy link
Contributor Author

refack commented Mar 10, 2019 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5188/
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5189/
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5190/ worker-1 ✔️
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5191/ worker-2 ✔️

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 10, 2019
@refack refack added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 10, 2019
@refack
Copy link
Contributor Author

refack commented Mar 10, 2019

Actually since right now master is broken, I'd like to fast-track this.
Please 👍 here.

@refack
Copy link
Contributor Author

refack commented Mar 10, 2019 •
edited
Loading

New CI:
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5204/ worker-1 ✔️
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5205/ worker-2 ✔️

bnoordhuis
bnoordhuis reviewed Mar 11, 2019
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mention in the commit log the commit that introduced the bug? It's 9613221 "test: de-flake test-dns-idna2008.js", isn't it?

@refack
Copy link
Contributor Author

refack commented Mar 11, 2019

Can you mention in the commit log the commit that introduced the bug

Done.

@refack
Copy link
Contributor Author

refack commented Mar 12, 2019 •
edited
Loading

Ping @nodejs/testing, I'd like to land this tonight to unbreak master, PTAL.

CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5243/

@refack
test: fix syntax error in test-dns-idna2008.js when failing
f77555f 
Fixes a bug I introduced in 9613221

PR-URL: nodejs#26570
Refs: nodejs#25870
Refs: nodejs#26473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@refack refack removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 12, 2019
@refack refack merged commit f77555f into nodejs:master Mar 12, 2019
@refack refack deleted the fix-idna2008-test++ branch March 12, 2019 15:16
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@refack @BridgeAR
test: fix syntax error in test-dns-idna2008.js when failing
f03498c 
Fixes a bug I introduced in 9613221

PR-URL: #26570
Refs: #25870
Refs: #26473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@refack @BridgeAR
test: fix syntax error in test-dns-idna2008.js when failing
f2eeb38 
Fixes a bug I introduced in 9613221

PR-URL: #26570
Refs: #25870
Refs: #26473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 14, 2019
@refack @BridgeAR
test: fix syntax error in test-dns-idna2008.js when failing
155cc34 
Fixes a bug I introduced in 9613221

PR-URL: nodejs#26570
Refs: nodejs#25870
Refs: nodejs#26473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@refack @BridgeAR
test: fix syntax error in test-dns-idna2008.js when failing
e1a55e7 
Fixes a bug I introduced in 9613221

PR-URL: #26570
Refs: #25870
Refs: #26473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@refack refack removed their assignment Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
dns Issues and PRs related to the dns subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@refack @nodejs-github-bot @bnoordhuis @jasnell @Trott @cjihrig @BridgeAR