-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: inline macro DISALLOW_COPY_AND_ASSIGN #26634
src: inline macro DISALLOW_COPY_AND_ASSIGN #26634
Conversation
b1c31b5
to
8198e3b
Compare
Linting failed due to
|
That's strange since it's contrary to https://google.github.io/styleguide/cppguide.html#Copyable_Movable_Types:
I'd be +1 for unpacking the macro everywhere. Personally I'm ambivalent of it's use... On the one hand it has an nice explicit name. On the other hand it's non-language meta-programming (ES.30: Don’t use macros for program text manipulation & https://google.github.io/styleguide/cppguide.html#Preprocessor_Macros) I'll post a PR to patch cpplint.py. |
Personally I like to unpack them too. |
FTR: the reason behind this is |
Yeap, the pr I refered has the similar information.
|
I am thinking inline |
I don’t have a strong opinion on this, personally. |
If there is no strong objection on this, I can work on this on Sunday. |
8198e3b
to
46f5862
Compare
d21c189
to
c6dd193
Compare
54bfa35
to
6e9c44c
Compare
6e9c44c
to
156e239
Compare
Non blocking, but it would be nice to update the example in node/src/tracing/trace_event_common.h Lines 153 to 155 in 6608cf2
|
Done. |
156e239
to
138d76c
Compare
138d76c
to
45d9454
Compare
PR-URL: nodejs#26634 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: nodejs#26634 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
45d9454
to
dace489
Compare
Quick pre-land sanity: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2953/ |
PR-URL: nodejs#26634 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: nodejs#26634 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #26634 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #26634 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
This one is similar like #25764, following Effective Modern C++
Items 11: Prefer deleted functions to private undefined ones
.This time I tried this on godbolt.
When deleted functions are declared private,
GCC 6.2 error message is not very clear.
GCC 8.x and Clang 7.x error message is clear.
demo: https://godbolt.org/z/k6O9wc.
This commit also add commit
use deleted function instead of private function in class AsyncWrap
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes