Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add --inspect-brk-node #26639

Closed
wants to merge 1 commit into from
Closed

doc: add --inspect-brk-node #26639

wants to merge 1 commit into from

Conversation

aymen94
Copy link
Member

@aymen94 aymen94 commented Mar 13, 2019

added in cli documentation --inspect-brk-node.

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Mar 13, 2019
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should document this, it is for internal debugging only, similar to --expose-internals. It does not actually break on the first JS script ever executed anyway, because the inspector is not started at that point.

The users should use --inspect-brk instead.

@aymen94
Copy link
Member Author

aymen94 commented Mar 14, 2019

@joyeecheung Ok, thanks.
Is there an internal documentation?

@BridgeAR
Copy link
Member

@aymen94 we have a couple internal documentations. Pretty much everything that is not in ./doc/api/ is internal. I personally would not know a good spot to document this in but maybe others have a suggestion. Ping @Trott

@Trott
Copy link
Member

Trott commented Mar 14, 2019

Creating something in doc/guides for internal-only undocumented flags (like --expose-internals) would probably be the place to do it.

doc/guides is unfortunate naming because it looks like guides we write for external folks, but those are over in the website repo. At some point, we should rename doc/guides to something else to make it more clear, like doc/internal-guides or doc/project-guides or doc/internal or something like that.

@Trott
Copy link
Member

Trott commented Mar 14, 2019

I'm going to close this because we don't want this documented in end-user docs. Feel free to open a new PR for internal documentation though. That would be great.

@Trott Trott closed this Mar 14, 2019
@aymen94 aymen94 mentioned this pull request Mar 14, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants