Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: use DiagnosticFilename #26647

Merged
merged 2 commits into from
Mar 16, 2019
Merged

report: use DiagnosticFilename #26647

merged 2 commits into from
Mar 16, 2019

Conversation

richardlau
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@richardlau build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2898/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 14, 2019
@richardlau richardlau added the report Issues and PRs related to process.report. label Mar 14, 2019
cjihrig
cjihrig approved these changes Mar 14, 2019
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@richardlau
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/21519/

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 14, 2019
@richardlau richardlau changed the title report: use DiagnosticFilename for default filename report: use DiagnosticFilename Mar 14, 2019
@richardlau
Copy link
Member Author

Decided while I was editing here to also use LocalTime from DiagnosticFilename and get rid of the one in node_report.cc.

@richardlau
Copy link
Member Author

richardlau commented Mar 14, 2019 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/21520/ (✔️)

Above CI was started while node-test-commit-linux-containered was disabled, so: https://ci.nodejs.org/job/node-test-pull-request/21521/

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21529/ (✔️)

@richardlau
report: use DiagnosticFilename for default filename
d268114 
PR-URL: nodejs#26647
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@richardlau
report: use LocalTime from DiagnosticFilename
5a23a87 
PR-URL: nodejs#26647
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@richardlau
Copy link
Member Author

Landed in 969c63a...5a23a87.

@richardlau richardlau merged commit 5a23a87 into nodejs:master Mar 16, 2019
@richardlau richardlau deleted the reportfilename branch March 16, 2019 00:55
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@richardlau @targos
report: use DiagnosticFilename for default filename
391c311 
PR-URL: nodejs#26647
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@richardlau @targos
report: use LocalTime from DiagnosticFilename
9045474 
PR-URL: nodejs#26647
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@richardlau @targos
report: use DiagnosticFilename for default filename
e3bae20 
PR-URL: #26647
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@richardlau @targos
report: use LocalTime from DiagnosticFilename
5c41876 
PR-URL: #26647
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@richardlau @nodejs-github-bot @jasnell @cjihrig @joyeecheung @BridgeAR