Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build,deps,v8: loose ends #26666

Merged
merged 1 commit into from
Mar 16, 2019
Merged

build,deps,v8: loose ends #26666

merged 1 commit into from
Mar 16, 2019

Conversation

refack
Copy link
Contributor

@refack refack commented Mar 14, 2019

Some loose ends for #25852

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Mar 14, 2019
@refack
Copy link
Contributor Author

refack commented Mar 14, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21550/
/CC @nodejs/v8-update @nodejs/build-files if this passes CI I'd like to fast-track this, as it makes #25852 more correct. Please 👍 here if you agree.

@refack refack added build Issues and PRs related to build files or the CI. dont-land-on-v6.x fast-track PRs that do not need to wait for 48 hours to land. labels Mar 14, 2019
@refack refack self-assigned this Mar 14, 2019
@refack refack requested review from targos and ryzokuken March 14, 2019 18:27
@Trott
Copy link
Member

Trott commented Mar 14, 2019

Micro-nit: Commit message first word should be an imperative verb, so maybe tie up loose ends or take care of loose ends or something like that?

deps/v8/gypfiles/v8.gyp Outdated Show resolved Hide resolved
deps/v8/gypfiles/v8.gyp Outdated Show resolved Hide resolved
deps/v8/gypfiles/v8.gyp Outdated Show resolved Hide resolved
Copy link
Contributor Author

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed comments

deps/v8/gypfiles/v8.gyp Outdated Show resolved Hide resolved
deps/v8/gypfiles/v8.gyp Outdated Show resolved Hide resolved
deps/v8/gypfiles/v8.gyp Outdated Show resolved Hide resolved
deps/v8/gypfiles/v8.gyp Outdated Show resolved Hide resolved
Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Much needed.

@refack refack removed the fast-track PRs that do not need to wait for 48 hours to land. label Mar 15, 2019
PR-URL: nodejs#26666
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants