Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: tidy function arguments in eslint rules #26668

Closed
wants to merge 1 commit into from
Closed

tools: tidy function arguments in eslint rules #26668

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 14, 2019

Remove unused arguments from function invocations in ESLint custom
rules.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
tools: tidy function arguments in eslint rules
a5da227 
Remove unused arguments from function invocations in ESLint custom
rules.
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2911/pipeline

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 14, 2019
@Trott
Copy link
Member Author

Trott commented Mar 14, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21555/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 14, 2019
@Trott
Copy link
Member Author

Trott commented Mar 17, 2019

Landed in 2f9c9ee

@Trott Trott closed this Mar 17, 2019
Trott added a commit to Trott/io.js that referenced this pull request Mar 17, 2019
@Trott
tools: tidy function arguments in eslint rules
2f9c9ee 
Remove unused arguments from function invocations in ESLint custom
rules.

PR-URL: nodejs#26668
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@Trott @targos
tools: tidy function arguments in eslint rules
dd7bb05 
Remove unused arguments from function invocations in ESLint custom
rules.

PR-URL: nodejs#26668
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Mar 27, 2019
@Trott @targos
tools: tidy function arguments in eslint rules
72cda51 
Remove unused arguments from function invocations in ESLint custom
rules.

PR-URL: #26668
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Mar 27, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
@Trott @BethGriggs
tools: tidy function arguments in eslint rules
3445080 
Remove unused arguments from function invocations in ESLint custom
rules.

PR-URL: #26668
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the tidy-sigs branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@watilde watilde watilde approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @nodejs-github-bot @watilde @cjihrig @richardlau @BridgeAR