Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: use Object spread instead of Object.assign #26673

Closed
wants to merge 1 commit into from
Closed

lib: use Object spread instead of Object.assign #26673

wants to merge 1 commit into from

Conversation

JungMinu
Copy link
Member

To optimize performance, use Object spread instead of Object.assign

Performance comparison chart

performance

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@JungMinu build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2915/pipeline

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Mar 15, 2019
@JungMinu
lib: use Object spread instead of Object.assign
c1cbd55 
To optimize performance, use Object spread instead of Object.assign
See https://pbs.twimg.com/media/DhZgaLJWkAAC2CU.jpg for comparison
@JungMinu JungMinu closed this Mar 15, 2019
@baby636 baby636 mentioned this pull request Jul 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JungMinu @nodejs-github-bot