Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update ESLint to 5.15.2 #26687

Closed
wants to merge 1 commit into from
Closed

tools: update ESLint to 5.15.2 #26687

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 15, 2019

Update ESLint to 5.15.2

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@cjihrig
tools: update ESLint to 5.15.2
6979cbc 
Update ESLint to 5.15.2
@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2925/pipeline

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 15, 2019
richardlau
richardlau approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21579/

Trott
Trott approved these changes Mar 16, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 17, 2019
@danbev
Copy link
Contributor

danbev commented Mar 18, 2019

Landed in 1ceb6d8.

@danbev danbev closed this Mar 18, 2019
danbev pushed a commit that referenced this pull request Mar 18, 2019
@cjihrig @danbev
tools: update ESLint to 5.15.2
1ceb6d8 
Update ESLint to 5.15.2

PR-URL: #26687
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@cjihrig cjihrig deleted the eslint branch March 18, 2019 13:16
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@cjihrig @targos
tools: update ESLint to 5.15.2
3f8ec17 
Update ESLint to 5.15.2

PR-URL: nodejs#26687
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@cjihrig @targos
tools: update ESLint to 5.15.2
30d7f67 
Update ESLint to 5.15.2

PR-URL: #26687
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @nodejs-github-bot @BridgeAR @danbev @Trott @richardlau