report: tidy up included headers #26697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
jasnell
approved these changes
Mar 16, 2019
gengjiawen
approved these changes
Mar 16, 2019
addaleax
approved these changes
Mar 16, 2019
cjihrig
approved these changes
Mar 16, 2019
|
Found some more unnecessarily included headers since we use New CI: https://ci.nodejs.org/job/node-test-pull-request/21597/ |
BridgeAR
approved these changes
Mar 17, 2019
BridgeAR
added
the
author ready
|
Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21609/ (✔️) |
refack
approved these changes
Mar 17, 2019
tniessen
approved these changes
Mar 18, 2019
richardlau
force-pushed
the
offwithhisheader
branch
from
7cbaf6a
to
cd93d2d
Compare
Remove inclusion of headers that are no longer required. PR-URL: nodejs#26697 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
richardlau
force-pushed
the
offwithhisheader
branch
from
cd93d2d
to
993bdff
Compare
|
Landed in 993bdff. |
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
Remove inclusion of headers that are no longer required. PR-URL: nodejs#26697 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
Remove inclusion of headers that are no longer required. PR-URL: #26697 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove inclusion of headers that are no longer required.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes