Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: reduce internal usage of public require of util #26762

Closed
wants to merge 1 commit into from
Closed

assert: reduce internal usage of public require of util #26762

wants to merge 1 commit into from

Conversation

sasurau4
Copy link
Contributor

@sasurau4 sasurau4 commented Mar 19, 2019 •
edited
Loading

Refs: #26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the assert Issues and PRs related to the assert subsystem. label Mar 19, 2019
@ZYSzys
Copy link
Member

ZYSzys commented Mar 19, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21651/

@ZYSzys
Copy link
Member

ZYSzys commented Mar 19, 2019 •
edited
Loading

Resume CI:
https://ci.nodejs.org/job/node-test-pull-request/21653/✅

@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 19, 2019
@joyeecheung joyeecheung mentioned this pull request Mar 20, 2019
Closed
@BridgeAR
Copy link
Member

Landed in de3b164.

@sasurau4 congratulations on your first commit to Node.js! 🎉

@BridgeAR BridgeAR closed this Mar 21, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 21, 2019
@sasurau4 @BridgeAR
assert: reduce internal usage of public require of util
de3b164 
PR-URL: nodejs#26762
Refs: nodejs#26546
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@sasurau4 @targos
assert: reduce internal usage of public require of util
8dd5f6e 
PR-URL: nodejs#26762
Refs: nodejs#26546
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Mar 27, 2019
@sasurau4 @targos
assert: reduce internal usage of public require of util
db7c4ac 
PR-URL: #26762
Refs: #26546
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@shisama shisama shisama approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sasurau4 @ZYSzys @BridgeAR @shisama @nodejs-github-bot