Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: reduce internal usage of public require of util #26769

Closed
wants to merge 1 commit into from
Closed

child_process: reduce internal usage of public require of util #26769

wants to merge 1 commit into from

Conversation

toshi1127
Copy link
Contributor

Remove the usage of public require('util'), as described in issue:
#26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added the child_process Issues and PRs related to the child_process subsystem. label Mar 19, 2019
@toshi1127 toshi1127 mentioned this pull request Mar 19, 2019
Closed
@shisama
Copy link
Contributor

shisama commented Mar 20, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21690/

@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 22, 2019
@ZYSzys
Copy link
Member

ZYSzys commented Mar 22, 2019

Landed in 382e859

@toshi1127 congratulations for your contribution to Node.js! 🎉

@ZYSzys ZYSzys closed this Mar 22, 2019
ZYSzys pushed a commit that referenced this pull request Mar 22, 2019
@toshi1127 @ZYSzys
child_process: reduce internal usage of public require of util
382e859 
PR-URL: #26769
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Mar 28, 2019
@toshi1127 @targos
child_process: reduce internal usage of public require of util
370fc0d 
PR-URL: #26769
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Mar 30, 2019
@toshi1127 @targos
child_process: reduce internal usage of public require of util
4defe47 
PR-URL: #26769
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@shisama shisama shisama approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. child_process Issues and PRs related to the child_process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@toshi1127 @shisama @ZYSzys @jasnell @BridgeAR @nodejs-github-bot