Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http.IncomingMessage: fix forgotten 'message' to 'socket' #2677

Closed
wants to merge 1 commit into from
Closed

http.IncomingMessage: fix forgotten 'message' to 'socket' #2677

wants to merge 1 commit into from

Conversation

joozek78
Copy link

@joozek78 joozek78 commented Sep 3, 2015

No description provided.

@ChALkeR ChALkeR added the doc Issues and PRs related to the documentations. label Sep 3, 2015
@mscdex
Copy link
Contributor

mscdex commented Sep 3, 2015

There's another reference (request.connection) in that same document in http.Server's connection event description. Would you mind changing that as well while we're in there?

@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Sep 3, 2015
@joozek78
Copy link
Author

joozek78 commented Sep 3, 2015

@mscdex Amended

@silverwind
Copy link
Contributor

@joozek78 something is wrong with this PR. Could you attempt a rebase or file a new one?

@joozek78
Copy link
Author

@silverwind rebased

@jasnell
Copy link
Member

jasnell commented Nov 5, 2015

LGTM. @silverwind PTAL

@silverwind
Copy link
Contributor

What's the reasoning behind this? Are we going to deprecate .connection eventually?

@jasnell
Copy link
Member

jasnell commented Nov 16, 2015

Actually, looking it over again, I retract my LGTM. Not seeing the reasoning behind this.

@jasnell jasnell added the stalled Issues and PRs that are stalled. label Dec 14, 2015
@silverwind
Copy link
Contributor

Closing because of inactivity.

@silverwind silverwind closed this Feb 28, 2016
@kissofire kissofire mentioned this pull request Feb 18, 2021
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Feb 18, 2021
Open
@ron-a20 ron-a20 mentioned this pull request Feb 19, 2021
Open
@sitedata sitedata mentioned this pull request Feb 19, 2021
Open
@meghasfdc meghasfdc mentioned this pull request Feb 19, 2021
Open
@137717unity 137717unity mentioned this pull request Feb 19, 2021
Open
@Rednickle Rednickle mentioned this pull request Feb 19, 2021
Open
This was referenced Mar 11, 2021
Open
Open
@snyk-bot snyk-bot mentioned this pull request Jun 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. stalled Issues and PRs that are stalled.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joozek78 @mscdex @silverwind @jasnell @ChALkeR