Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: remove util.inherits in tty.js #26797

Closed
wants to merge 2 commits into from
Closed

lib: remove util.inherits in tty.js #26797

wants to merge 2 commits into from

Conversation

nissy-dev
Copy link
Contributor

@nissy-dev nissy-dev commented Mar 20, 2019 •
edited
Loading

This PR is part of issue #26546

Replaced usage of require('util')

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tty Issues and PRs related to the tty subsystem. label Mar 20, 2019
ZYSzys
ZYSzys reviewed Mar 20, 2019
View reviewed changes
lib/tty.js Show resolved Hide resolved
lib/tty.js Show resolved Hide resolved
@joyeecheung joyeecheung mentioned this pull request Mar 20, 2019
Closed
@nissy-dev
Copy link
Contributor Author

Thank you for your advice 🙇
I could fix the build error!

@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21770/

@joyeecheung joyeecheung mentioned this pull request Mar 22, 2019
Closed
@ZYSzys
Copy link
Member

ZYSzys commented Mar 22, 2019

Resume: https://ci.nodejs.org/job/node-test-pull-request/21785/

@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 22, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 24, 2019
@nissy-dev @BridgeAR
tty: remove util.inherits usage
55e6c68 
PR-URL: nodejs#26797
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@BridgeAR
Copy link
Member

Landed in 55e6c68

@nd-02110114 congratulations on your first commit to Node.js! 🎉 Keep up the good work!

@BridgeAR BridgeAR closed this Mar 24, 2019
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@nissy-dev @targos
tty: remove util.inherits usage
1b1314d 
PR-URL: nodejs#26797
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@nissy-dev @targos
tty: remove util.inherits usage
83f6ec8 
PR-URL: #26797
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tty Issues and PRs related to the tty subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nissy-dev @BridgeAR @ZYSzys @nodejs-github-bot