module: remove usage of require('util') in esm/translators.js
#26806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dnlup
force-pushed
the
util_internal_modules_esm_translators
branch
from
28508c7
to
edfa70f
Compare
dnlup
changed the title
esm/translators.js
jasnell
reviewed
Mar 21, 2019
| @@ -19,7 +19,8 @@ const { | |||
| StringPrototype | |||
| } = primordials; | |||
| const { URL } = require('url'); | |||
| const { debuglog, promisify } = require('util'); | |||
| const debuglog = require('internal/util/debuglog').debuglog; | |||
There was a problem hiding this comment.
Suggested change
| const debuglog = require('internal/util/debuglog').debuglog; | |
| const { debuglog } = require('internal/util/debuglog'); |
jasnell
reviewed
Mar 21, 2019
| @@ -19,7 +19,8 @@ const { | |||
| StringPrototype | |||
| } = primordials; | |||
| const { URL } = require('url'); | |||
| const { debuglog, promisify } = require('util'); | |||
| const debuglog = require('internal/util/debuglog').debuglog; | |||
| const promisify = require('internal/util').promisify; | |||
There was a problem hiding this comment.
Suggested change
| const promisify = require('internal/util').promisify; | |
| const { promisify } = require('internal/util'); |
jasnell
approved these changes
Mar 21, 2019
Use `require('internal/util/debuglog').debuglog` and
`require('internal/util').promisify`
instead of `require('util').debuglog` and `require('util').promisify` in
`lib/internal/modules/translators.js`.
Refs: nodejs#26546
dnlup
force-pushed
the
util_internal_modules_esm_translators
branch
from
edfa70f
to
cb61931
Compare
BridgeAR
approved these changes
Mar 22, 2019
BridgeAR
added
the
author ready
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 24, 2019
Use `require('internal/util/debuglog').debuglog` and
`require('internal/util').promisify`
instead of `require('util').debuglog` and `require('util').promisify` in
`lib/internal/modules/translators.js`.
PR-URL: nodejs#26806
Refs: nodejs#26546
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in 0f2bf72 🎉 |
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
Use `require('internal/util/debuglog').debuglog` and
`require('internal/util').promisify`
instead of `require('util').debuglog` and `require('util').promisify` in
`lib/internal/modules/translators.js`.
PR-URL: nodejs#26806
Refs: nodejs#26546
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
Use `require('internal/util/debuglog').debuglog` and
`require('internal/util').promisify`
instead of `require('util').debuglog` and `require('util').promisify` in
`lib/internal/modules/translators.js`.
PR-URL: #26806
Refs: #26546
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
require('internal/util/debuglog').debuglogandrequire('internal/util').promisifyinstead of
require('util').debuglogandrequire('util').promisifyinlib/internal/modules/translators.js.Refs: #26546
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes