Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: stricter settings validation #26811

Closed
wants to merge 2 commits into from
Closed

http2: stricter settings validation #26811

wants to merge 2 commits into from

Commits on Mar 20, 2019

  1. http2: remove side effects from validateSettings 

    The function did not only validate the input so far but it also made
a copy of the input object and returned that copy to the callee
function. That copy was not necessary for all call sites and it was
not obvious that the function did not only validate the input but
that it also returned a copy of it. This makes sure the function does
nothing more than validation and copying is happening in the callee
function when required.
    @BridgeAR
    BridgeAR committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    4b70d2d View commit details
    Browse the repository at this point in the history

  2. http2: validate settings input 

    The settings input was not marked as optional in our documentation
but we did not throw an error in those cases. The API does not seem
to be useful without the correct input, so I went for throwing an
error in such cases instead of updating the documentation.
    @BridgeAR
    BridgeAR committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    5c1b27f View commit details
    Browse the repository at this point in the history